TheGag96 / individual-color-variation

Pokémon Platinum hack to make individual Pokémon have a unique color variation (+ some shiny color changes).
18 stars 3 forks source link

Remove needless code #2

Closed TheGag96 closed 3 years ago

TheGag96 commented 4 years ago

In Hijack_PersonalityTableBuild.s, there's some code attemps to determine if a party is empty in order to determine which party index corresponds with the current loop variable. I realized that even in a double battle where you have no partner, party 2, which would normally be the index of your partner if one was there, will still redirect to party 0, which is the player. So, it seems like I can just simply use the loop variable for the code below and not worry about resolving which party I'm in.

I didn't remove the code before pushing because the hue shifting was working and I was afraid to touch it. Need to go back and check if this is alright - it should be, because that part of the code doesn't actually work because the party index redirection will make it report that party 2 has Pokemon in it.

TheGag96 commented 3 years ago

Fixed by d3704e8d3d10020654b4a253256519db26660675.