TheHive-Project / TheHive

TheHive: a Scalable, Open Source and Free Security Incident Response Platform
https://thehive-project.org
GNU Affero General Public License v3.0
3.46k stars 626 forks source link

[Feature Request] Option to disable Case Merging as Merged cases "disappear" #1900

Open crackytsi opened 3 years ago

crackytsi commented 3 years ago

Request Type

Feature Request

Work Environment

Question Answer
OS version (server) Debian
OS version (client) 10
TheHive version / git hash 4.1.1
Package Type DEB

Problem Description

The new introduced case-merging capabilities of TH4 lead to the situtation that the original cases are deleted. In the past, these cases was just closed with status "closed as duplicate". Actually in some siutation case merging is not wanted, because it introduces a complexity that can't be handled on connected systems or integration. If you have a synchronization between cases and an external system (e.g. a SIEM Case Management system) you loose to connection and the case is just "not available" (for which reason).

Steps to Reproduce

  1. Add TheHive CaseID in an external system
  2. Try to find the case by caseid

Possible Solutions

An option to disable merging on the GUI could give per organisation the option to disable that functionality and keep compatibility with connected cases/alerts/objects.

nadouani commented 3 years ago

Hi @crackytsi I think that adding an option to disable the feature makes sense.

But if we keep the feature enabled, removing existing cases after the merge is the way to go. Case merging in TheHive 3 that keep the cases as duplicate is not how we want it in TheHive 4.

Anything related to integration with other systems need to be handled by the glue between TheHive and the 3rd party system.

martinr103 commented 2 years ago

I know that this comment is waay too late. And probably will not change anything anymore. (since TH5 is there)

But I don't agree with you @nadouani. The "TH3-style" of merging cases was a lot more 'flexible', not as rigid as TH4.

Imagine the very realistic scenario:

So yeah.. Why the TH4-style of merging cases is better than TH3 (ie completely deleting them, instead of marking them as merged, but still keeping the IDs) is beyond me. I do agree with @crackytsi.