TheIOFoundation / ProjectLockdown

Project Lockdown (an initiative from The IO Foundation) is a civic tech, interactive platform providing an overview of the state of Human and Digital Rights around the globe. It evaluates policies obtained from official sources that may impact their observance. It provides, among other tools, a layered map interface that allows for a visual representation of the policies adopted, assisting a broad range of stakeholders in understanding the global state of their Rights. This empowers them to become active agents of global change.
https://ProjectLockdown.world
GNU General Public License v3.0
36 stars 14 forks source link

Fredrick/issue 314/git action integration #346

Open iamfredrickokereke opened 3 years ago

iamfredrickokereke commented 3 years ago

Hi Jeff,

Kindly check and review, I will make necessary corrections as required.

Thank you.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jeff-knurek commented 3 years ago

I guess the first thing that needs to be addressed is that it works on it's own: https://github.com/TheIOFoundation/ProjectLockdown/pull/346/checks?check_run_id=2064650228

  env:
    AZURE_WEBAPP_NAME: your-app-name
    AZURE_WEBAPP_PACKAGE_PATH: .
Error: Unable to find Node version '10.x, 11.x, 12.x, 13.x, 14.x' for platform linux and architecture x64.
netlify[bot] commented 3 years ago

:heavy_check_mark: Deploy Preview for dazzling-visvesvaraya-f47271 ready!

:hammer: Explore the source changes: e09ab9b8964fb69550665095cbbdc361935eb063

:mag: Inspect the deploy log: https://app.netlify.com/sites/dazzling-visvesvaraya-f47271/deploys/60d09bd706ce030008206ef6

:sunglasses: Browse the preview: https://deploy-preview-346--dazzling-visvesvaraya-f47271.netlify.app

iamfredrickokereke commented 3 years ago

This works now, however, the test script in the API directory failed as shown attached:

image

iamfredrickokereke commented 3 years ago

New changes updated

jeff-knurek commented 3 years ago

there's a couple dependencies that changed in the package.json file. the only change should be the 2.0.0 change

Screenshot from 2021-06-30 18-09-36

iamfredrickokereke commented 3 years ago

Recent changes updated now.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

squash-labs[bot] commented 1 year ago

Manage this branch in Squash

Test this branch here: https://fredrickissue-314git-action-in-vs2c7.squash.io