search

TheNexusAvenger / Nexus-VR-Character-Model

Maps Roblox characters to the VR inputs of players.
MIT License
65 stars 12 forks source link

Fix camera not moving after death #28

Closed noblereign closed 10 months ago

noblereign commented 10 months ago

Addresses #27 i actually had this fix for a while in kit battle (albeit a lot more scuffed looking than this PR) should probably test it to make sure it works on your end as well, i'm not very confident in my github abilities LOL

TheNexusAvenger commented 10 months ago

I will be delayed getting to this one. The release candidate for 2.7.0 was created last night and I don't want to delay the release for this.

noblereign commented 10 months ago

OH i never realized it was supposed to be using spaces, no wonder it looked all goofy in the diff 💀 i'll go and test with headlocked and make the changes

noblereign commented 10 months ago

okay i tested with 2.7.0 to see when the bug happens, surprisingly it now happens only when HeadLocked is forced to false let me see if i can figure out how to fix it

TheNexusAvenger commented 10 months ago

surprisingly it now happens only when HeadLocked is forced to false let me see if i can figure out how to fix it

That is the behavior I expected. CameraService:UpdateCamera should be able to handle this internally.

noblereign commented 10 months ago

GITHUB IS SO CONFUSING jfc

noblereign commented 10 months ago

i cannot be bothered to figure out how to 'fix' my fork so i'm gonna make a new one and submit the actual good changes over there give me a sec