Closed T0nci closed 1 month ago
Sadly I tried installing Redis through the CLI(with 2 methods on their site) and both times my VM wouldn't start up. So I had to remove it. Thanks for testing the rotation commands locally!
Yes of course! I was searching for the markdown-lint
package and couldn't find it.
In what line is that? I can't seem to find it. I call getUsers
in every test without a number, so I get all users from the function.
In what line is that? I can't seem to find it. I call getUsers in every test without a number, so I get all users from the function.
In all of your new tests for the rotation service, you call getUsers()
without any args which will return the whole users array which you then slice out the first two elements. If you call getUsers(2)
then it'll return the first two sliced out already, so no need to slice again.
(+ you wouldn't have found anything for markdownlint because it's not the curriculum repo and there's no markdown :P We use ESLint and Prettier in this repo)
Oh I see. I was calling getUsers
without args to get more users to simulate a more "real" test server(which doesn't make sense :/) and now I see that all that extra mock data is unnecessary. I will update the tests.
OH I only got it now lol, MARKDOWNlint for MARKDOWN files xD
Because
When users had markdown in their username/nickname(display name) and the bot printed the user's display name in some commands, the markdown wasn't escaped and it caused unwanted formatting in the bot's reply.
This PR
escapeMarkdown
wherever a display name is mentioned in the points commandescapeMarkdown
wherever a username/nickname is mentioned in the rotation commandIssue
Closes #571
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Callbacks command: Update verbiage
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section