ThePandemoniumInstitute / botc-release

The Official Blood on the Clocktower App
https://botc.app
35 stars 2 forks source link

Vote bug. #136

Closed Edynol123 closed 8 months ago

Edynol123 commented 8 months ago

Describe the bug Sometimes when someone lowers their hand at the last second, it still counts their vote.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A vote to not count when a players lowers their hand.

Screenshots If applicable, add screenshots to help explain your problem. Try to include a screenshot of the browser console as well, if you're using the browser version. (Windows/Linux: Shift + CTRL + J, Mac: Option + ⌘ + J or Option + ⌘ + C)

Browser app (please complete the following information):

Standalone app (please complete the following information):

Additional context Add any other context about the problem here.

bra1n commented 8 months ago

Hi @Edynol123, what you describe is something that can happen in every game with an online service. If your connection to the game server is slower than your reaction speed, you will end up missing the point in time where you can do something (like voting) at the last moment. There isn't really anything I could do here easily, as code that "predicts" events like the vote clock hand is pretty complicated for very little gain. So my suggestion would be to not vote at the very last second, but ideally half a second earlier than that. ;-)