Expose stuff - Githubissues

ThePerfectComputer / FastWaveBackend

A Rust VCD parser intended to be the backend of a Waveform Viewer(built using egui) that supports dynamically loaded rust plugins.

GNU General Public License v3.0

42 stars 5 forks source link

Expose stuff #8

Closed TheZoq2 closed 1 year ago

TheZoq2 commented 1 year ago

These are the changes I need for my experimental vcd viewer so far:

Deriving extra traits for the indices is needed for me to efficiently keep track of the last time a signal was changed
Last timestamp is needed to figure out how wide to make the default view
byte_len_of_string_tmstmp_vals_on_tmln.push(curr_tmstmp_len_u8); fixes a panic when indexing into string values
SignalValue and associated functions properly expose the current value of the signal

BracketMaster commented 1 year ago

I suppose not including the range in the signal name makes sense. I suppose that when I started working on Fastwave, I had assumed there'd be a tighter coupling between the frontend viewer and the backend.

Was including the range causing issues for you?

TheZoq2 commented 1 year ago

It was, yes. The translation stuff i'm doing in python relies on the names being there in their pure form, and if I read the spec, it seems like the [] enclosed stuff shouldn't be included in the identifier

I'm open to actually saving them, but I forgot to do that before pushing btw

TheZoq2 commented 1 year ago

I made another change to make the whole lib generic over the io::Read implementation, which allows it to be used with https://docs.rs/progress-streams/latest/progress_streams/ (and I guess any other weird streams we can think of)