TheQwertiest / foo_spider_monkey_panel

foobar2000 component that allows to use JavaScript to create CUI/DUI panels
https://theqwertiest.github.io/foo_spider_monkey_panel/
MIT License
274 stars 21 forks source link

Apply button fail #130

Closed marc2k3 closed 3 years ago

marc2k3 commented 3 years ago

From the editor dialog, I expect to be able to hit the Apply button repeatedly if I want to test something...

But on the first click, it doesn't even reset the script. And after that first click it disables itself and won't become active until the text changes. That behaviour is so wrong!

TheQwertiest commented 3 years ago

I expect to be able to hit the Apply button repeatedly if I want to test something...

I'm genuinely curious, what things are you testing that require the reload of the script without actually changing the script?

But on the first click, it doesn't even reset the script.

Do you mean that after changing the script and clicking on Apply, the panel is not reloaded?

marc2k3 commented 3 years ago

Currently, the button does nothing. Removing it would make more sense logically.

TheQwertiest commented 3 years ago

That's strange (i.e. it should apply changes and it did when I tested it). How do you open the editor dialog? (coz there's different code for each scenario)

TheQwertiest commented 3 years ago

Actually, you are right - apply button does not work anymore, I'll take a look it if can be fixed.

TheQwertiest commented 3 years ago

It should work now =) (if there were any changes in the script) Thanks for reporting!