Incorrect relative path handling on Include

TheQwertiest / foo_spider_monkey_panel

foobar2000 component that allows to use JavaScript to create CUI/DUI panels

https://theqwertiest.github.io/foo_spider_monkey_panel/

MIT License

274 stars 21 forks source link

Incorrect relative path handling on Include #154

Closed regorxxx closed 2 years ago

regorxxx commented 2 years ago

Hi, I keep getting error reports about relative paths not working properly on 'include' function. https://github.com/regorxxx/Playlist-Tools-SMP/issues/5

There have been more in private and hydrogen threads. Last time has been with 1.6.1 release.

I know you have been absent due to real life, but this has been a pain in the ass since months. I keep repeating people it's not something I can fix... Any idea?

EDIT: I meant 1.6.1

TheQwertiest commented 2 years ago

There is additional logging feature included since v1.6.0 in Preferences: Advanced: log additional information when include fails that might help diagnosing the issue.

TheQwertiest commented 2 years ago

I can't fix it, because I've yet to manage to reproduce it...

regorxxx commented 2 years ago

I've yet to manage to reproduce it...

The same! Don't understand what's going on. Will ask the users who experienced it to check that additional logging and report.

regorxxx commented 2 years ago

https://github.com/regorxxx/Playlist-Tools-SMP/issues/5#issuecomment-1018860169

TheQwertiest commented 2 years ago

Judging by the comments, it doesn't seem that the problem was caused by the component. Closing.

regorxxx commented 2 years ago

No idea (?) did not really understand what was going on. XD

Will keep you informed if there are any news about this from any user.

regorxxx commented 2 years ago

Ok, new info! The issue should be reopened again.

When the advanced pref. at settings for Include logging is enabled, foobar instance crashes if the file is not found. So that was the crash the user was experiencing... (and the logging option has been useless all this time)

Arbitrary code: include('a.js');

Setting disabled -> Ok (just panel crash): And a standard panel crash popup happens:
Setting enabled-> Foobar crash:

regorxxx commented 2 years ago

Also note once the setting has been enabled, the foobar installation becomes blocked for all purposes, since restarting it will trigger a crash again while the panel runs the included line. (And you must either delete the script file -if it was not "in memory"-, or delete the Spider Monkey config file to be able to innit foobar properly)-.

That was also the second part experienced by the user, who had to "reinstall foobar".

TheQwertiest commented 2 years ago

crash when using debug output fixed on dev build