TheQwertiest / foo_spider_monkey_panel

foobar2000 component that allows to use JavaScript to create CUI/DUI panels
https://theqwertiest.github.io/foo_spider_monkey_panel/
MIT License
274 stars 21 forks source link

Blank configuration problem with event handlers #181

Closed dima-lur closed 2 years ago

dima-lur commented 2 years ago

I don't know if it's worth opening a bug when it's found in the dev build, but here's one: event handlers (on_size, on_paint) never called in script if you've created a new blank configuration of SMP panel. Аnd they continue to be ignored on subsequent launches of the player, but the text of the script is saved normally.

TheQwertiest commented 2 years ago

That's weird, I'll look into it, thanks

TheQwertiest commented 2 years ago

I've checked the latest dev build and it seems to work fine: https://ci.appveyor.com/api/buildjobs/n3dwxs7sge90cfw8/artifacts/_result%2FWin32_Release%2Ffoo_spider_monkey_panel.fb2k-component

Artifact publishing for dev builds was broken for quite a while, so perhaps you were using outdated and broken dev build?

dima-lur commented 2 years ago

Hm. My steps are obvious (just made from scratch): 1) git clone https://github.com/TheQwertiest/foo_spider_monkey_panel cd foo_spider_monkey_panel\scripts setup.py 2) Run workspaces\foo_spider_monkey_panel.sln with MSVC 2022 17.3.1 3) Select Release Win32 & build 4) Run scripts\pack_component.py 5) Copy _result\Win32_Release\foo_spider_monkey_panel.fb2k-component contents to player;s plugin dir 6) Add SMP panel -> blank white panel (example script not working)

TheQwertiest commented 2 years ago

Hm... Still can't reproduce. Could you try the dev build that I've linked above?

TheQwertiest commented 2 years ago

And just to make sure, you are on master branch, right? Because this is an expected behaviour for v2 branch

TheQwertiest commented 2 years ago

Nevermind, I've reproduced the problem, thanks

dima-lur commented 2 years ago

Yeah, master branch by default.

Same result (link above)

TheQwertiest commented 2 years ago

Should be fixed now :)