TheQwertiest / foo_spider_monkey_panel

foobar2000 component that allows to use JavaScript to create CUI/DUI panels
https://theqwertiest.github.io/foo_spider_monkey_panel/
MIT License
274 stars 21 forks source link

ColourPicker default color does not match shown color #203

Open regorxxx opened 1 year ago

regorxxx commented 1 year ago

I suppose this is native win behavior... but well, it's really confusing that the displayed color when opening the popup does not match the default color passed.

marc2k3 commented 1 year ago

The original code I wrote for JSP absolutely behaves in the way you would expect.

colour

It was for the 1.2.x series which predates SMP by quite some time so any breakage copying/reimplementing the code is a bug.

regorxxx commented 1 year ago

Must be that then, It has been this way since I started creating scripts, that's why I thought it was a Win native thing.

(also the custom colors are never saved btw)

bug

marc2k3 commented 1 year ago

My original implementation did not remember custom colours either. I added it at a later date when it was pointed out to me.

Not my repo but I don't have any other copy of the old version changelog online....

https://github.com/razielanarki/foo_jscript_panel/blob/main/CHANGELOG.md#v2301