search

TheRedBrain / rpg-inventory

MIT License
1 stars 0 forks source link

Duplicating item from main hand & dissapearing #14

Closed x3Michels closed 4 months ago

x3Michels commented 4 months ago

So with a few friends we found we can duplicate everything that was on the first slot of the left hand(this is a god thing) The problem is, can replace other weapons or tools in the inventory slots(really a bad thing) image So The Problem is the "Advanced Feeding Upgrade" from the mod "Sophisticated Backpapcks" and the slot that you leave after changin to the main hand(item are in there. image So everytime it eat for being hungry or when hurt, It will be replaced the blank slot or item for the one is on the main hand

https://github.com/user-attachments/assets/9c365cdc-af08-44d2-9af1-1fbde79c4c1e

sorry for the bad quality, I doesnt know where to upload the video for make it easy for you to see..

TheRedBrain commented 4 months ago

Thank you for the report!

I will investigate.

The videos are a great help, the quality is absolutely okay

TheRedBrain commented 4 months ago

As far as I can tell there is nothing I can do from my side.

The Feeding Upgrade places the item equipped in the main hand into to currently selected hot bar slot after the feeding. If the item would be equipped into the main hand slot, everything would work as intended. (as far as I can tell after looking at their code for 5 minutes)

To solve this problem, either an add-on mod is needed or the FeedingUpgradeWrapper#tryFeedingFoodFromStorage method in SophisticatedCore needs to be changed to the behaviour described above.

Salandora commented 4 months ago

So Looked into the issue and thanks to your analysis it became a pretty easy fix, so should be fixed in the next sophisticatedcore version.

TheRedBrain commented 4 months ago

oh cool, that's good to hear! Cheers!