search

TheRosettaFoundation / SOLAS-Match

Self-managed translation project interface
www.TheRosettaFoundation.org
GNU Lesser General Public License v3.0
12 stars 8 forks source link

User can potentially claim a Task which is Already Claimed #1236

Closed alanbarrett closed 8 years ago

alanbarrett commented 8 years ago

A User can potentially claim a Task which is Already Claimed. Access to http://trommons.org/task/???/claim/ (task.claim.tpl which includes task.claim-translation.tpl etc.) is not stopped and it will also be possible to claim a task.

Note: http://trommons.org/task/???/id if accessed by manually creating the URL or otherwise will give a warning "This task has been claimed by another user" and not bring the user to task.claim.tpl

However it is possible to go there directly if you manually create the URL http://trommons.org/task/???/claim/

Additionally PROCEDURE claimTask(IN tID INT, IN uID INT) allows two users to claim the same task.

Note: SELECT COUNT(_), task_id FROM TaskClaims GROUP BY taskid HAVING COUNT()>1; is empty, which means this has not been done.

Alan.
alanbarrett commented 8 years ago

Database part moved to separate issue (it is lower priority)...

https://github.com/TheRosettaFoundation/SOLAS-Match/issues/1238

alanbarrett commented 8 years ago

Commit 5819361774a9b96b2c99dbb5d0110f6eb719df63 fixes