search

TheSGJ / nextjs-toploader

A Next.js Top Loading Bar component made using nprogress, works with Next.js 14 , Next.js 13 and React.
https://www.npmjs.com/package/nextjs-toploader
MIT License
867 stars 50 forks source link

Don't trigger start animation when opening in new tab (CTRL + Click) #53

Open duncanbla974 opened 1 year ago

duncanbla974 commented 1 year ago

I did see this issue, but it has been closed and the problem is still here. Seems like the ctrlKey didn't work for all of us. Is there any other workaround ?

tomcru commented 1 year ago

same happening here 👋 I think this is an issue because of Mac, and it using event.metaKey not ctrlKey?

Since this is taking a long while to fix and PRs are not getting merged, I've created Holy Loader as an alternative.

iFlyinq commented 1 year ago

Nice work!

dlibis commented 10 months ago

i have this issue occurring on macOS, when using cmd+click. the loader seems "stuck".

im using latest nextjs-toploader version: 1.6.4

TheSGJ commented 10 months ago

i have this issue occurring on macOS, when using cmd+click. the loader seems "stuck".

im using latest nextjs-toploader version: 1.6.4

Can you try using the latest version: 1.6.5, and can you tell if the loader works when using cmd + click on macOs now on version 1.6.5 or not.

rodrigocipriani commented 10 months ago

I've created this PR and now it's working good on my MAC

https://github.com/TheSGJ/nextjs-toploader/pull/67/

dlibis commented 9 months ago

i have this issue occurring on macOS, when using cmd+click. the loader seems "stuck". im using latest nextjs-toploader version: 1.6.4

Can you try using the latest version: 1.6.5, and can you tell if the loader works when using cmd + click on macOs now on version 1.6.5 or not.

yes, it works well now, good job!