TheSuperHackers / GeneralsGamePatch

Community Patch to fix and improve original Generals Zero Hour 1.04
Other
60 stars 20 forks source link

China Minigunner Has very large Range Against Air Units When Inside Buildings #2132

Open commy2 opened 1 year ago

commy2 commented 1 year ago

The Minigunner gets a range (and damage) bonus from being inside buildings, as do all other infantry. It also gains a huge range bonus when targeting airborne units as do most other anti air weapons (Towvee, Patriot, Gatling, Quad, Stinger etc.).

The issue is that these bonuses stack and compound, which results in a total anti air range that is larger than even stuff like scrapped up Scud Launchers (!).

unit / building garrisoned AA range
Missile Defender / Tank Hunter / RPG-Soldier no 175
Missile Defender / Tank Hunter / RPG-Soldier yes 232.75
Minigunner no 350
Minigunner yes 465.5
Gattling Gun - 400
Gattling Tank - 350
Avenger - 100
Patriot Battery - 350
Humvee Tow - 320
Humvee Tow S&D - 384
Quad Cannon - 350
Stinger Site - 400
Scud Launcher - 350 (vs ground)
scrapped up Scud Launcher - 450 (vs ground)

This is not a problem with rocketeers, because rocketeers don't get extra range against airborne targets.

Comparison (bottom Chinook is Bunker Minigunner, top Chinook is rest)

shot_20230721_113555_5

I think this much range is a bit excessive.

xezon commented 1 year ago

Duplicate of #300 ?

commy2 commented 1 year ago

300 is specifically about the Helix. I think this is an issue in general.

xezon commented 1 year ago

Do we need both reports?

commy2 commented 1 year ago

The other one goes too much into the weeds about the Helix imo. I think approaching all of this from this angle is more helpful.

MTKing4 commented 1 year ago

Didn't we have Hanfield fix for this?

commy2 commented 1 year ago

Depends on how you want to go about this. If the goal is to remove or reduce the range bonus, then just add a GARRISON malus to MinigunnerGunAir.

MTKing4 commented 1 year ago

What other options do we have over #357? Also what was that method? It's not explained what was done there, also looked weird when TC and Helix need to come too close for the minigunner to shoot, doesn't look normal

commy2 commented 1 year ago

357 is only about the Helix. This is about the Minigunner in every building/bunker.

MTKing4 commented 1 year ago

Ok but what was its method exactly? It wasn't explained

commy2 commented 1 year ago

Make Helix temporarily upgrade the weapons of the passengers. It's a weird unused feature of the engine. This gives e.g. RPG-Soldiers AP Rockets as long as they are inside the Helix. But you can also make it so Minigunners have an unreachable otherwise upgrade that reduces range.

MTKing4 commented 1 year ago

Hmmm interesting