search

TheThingsArchive / ttn

The Things Network Stack V2
https://www.thethingsnetwork.org
MIT License
461 stars 277 forks source link

Add RU_864_870 frequency plan to support LoRaWAN in Russia #737

Closed belovictor closed 5 years ago

belovictor commented 5 years ago

This pull request adds support for RU_864_870 frequency plan to support LoRaWAN in Russia. It includes a fix to brocaar library which was included into TTN code before the valid RU_864_870 was implemented in it and also updates version of api/protocol/lorawan dependency to the new one which has RU_864_870 in the list.

belovictor commented 5 years ago

All tests run fine on my side. Looks like a problem in build system again - something about certs :-(

belovictor commented 5 years ago

Just double checked: GOARCH=amd64 make test go test ./amqp ./api/pool ./cmd ./core/band ./core/broker ./core/component ./core/discovery ./core/discovery/announcement ./core/handler ./core/handler/application ./core/handler/cayennelpp ./core/handler/device ./core/handler/functions ./core/networkserver ./core/networkserver/device ./core/proxy ./core/router ./core/router/gateway ./core/storage ./core/types ./mqtt ./ttnctl/util ./utils/fcnt ./utils/otaa ./utils/parse ./utils/random ./utils/security ./utils/toa ok github.com/TheThingsNetwork/ttn/amqp 0.875s ok github.com/TheThingsNetwork/ttn/api/pool 1.632s ok github.com/TheThingsNetwork/ttn/cmd 0.601s ok github.com/TheThingsNetwork/ttn/core/band 0.034s ok github.com/TheThingsNetwork/ttn/core/broker 0.636s ok github.com/TheThingsNetwork/ttn/core/component 2.482s ok github.com/TheThingsNetwork/ttn/core/discovery 0.262s ok github.com/TheThingsNetwork/ttn/core/discovery/announcement 0.303s ok github.com/TheThingsNetwork/ttn/core/handler 2.718s ok github.com/TheThingsNetwork/ttn/core/handler/application 0.036s ok github.com/TheThingsNetwork/ttn/core/handler/cayennelpp 0.030s ok github.com/TheThingsNetwork/ttn/core/handler/device 0.045s ok github.com/TheThingsNetwork/ttn/core/handler/functions 0.044s ok github.com/TheThingsNetwork/ttn/core/networkserver 0.618s ok github.com/TheThingsNetwork/ttn/core/networkserver/device 0.052s ok github.com/TheThingsNetwork/ttn/core/proxy 0.038s ok github.com/TheThingsNetwork/ttn/core/router 0.355s ok github.com/TheThingsNetwork/ttn/core/router/gateway 0.953s ok github.com/TheThingsNetwork/ttn/core/storage 0.109s ok github.com/TheThingsNetwork/ttn/core/types 0.039s ok github.com/TheThingsNetwork/ttn/mqtt 2.408s ok github.com/TheThingsNetwork/ttn/ttnctl/util 0.801s ok github.com/TheThingsNetwork/ttn/utils/fcnt 0.010s ok github.com/TheThingsNetwork/ttn/utils/otaa 0.034s ok github.com/TheThingsNetwork/ttn/utils/parse 0.012s ok github.com/TheThingsNetwork/ttn/utils/random 0.024s ok github.com/TheThingsNetwork/ttn/utils/security 0.066s ok github.com/TheThingsNetwork/ttn/utils/toa 0.021s

belovictor commented 5 years ago

After having a look into this issue I found that make test uses an environment which is different from one used by Travis and make test doesn't perform MQTT tests with TLS. The reason for this Travis build error is expired certificate in .env/mqtt which expired on 21.08.2018. Unfortunately gencerts.sh in .env/ doesn't generate new certificate for MQTT, so I need some suggestion on how to proceed with this. Either somebody from the team will generate a new certificate to fix test builds or tell me the right way to do that so that I submit another pull request with new cert. @htdvisser can you please assist?

htdvisser commented 5 years ago

We're waiting for a few more changes in github.com/TheThingsNetwork/api and then will update the entire dependency.

htdvisser commented 5 years ago

I fixed gencerts.sh and re-generated the development certificates.

belovictor commented 5 years ago

Ok, so should I wait for new api integrated into ttn and then resubmit pull request?

htdvisser commented 5 years ago

I rebased the pull request on top of the changes we made. Should be ok now.

belovictor commented 5 years ago

Wow. Thanks a lot!