search

TheTorProject / bwscanner

Bandwidth authority scanner. This project is deprecated in favour of https://gitlab.torproject.org/tpo/network-health/sbws
GNU General Public License v2.0
38 stars 32 forks source link

Remove scripts/detect_partitions.py? #88

Closed juga0 closed 6 years ago

juga0 commented 6 years ago

The script and the associated doc is not really part of the scanner, so maybe we should put it in other repo?.

juga0 commented 6 years ago

What about creating a new dir/module, with the script, the needed dependencies in bwscanner and the associated tests. This way we could also skip for now the tests that are not related to the bwscanner itself. It should also go in other issue, but we could also create a new/dir module with all the code is not being used currently for the scanner, so that we still reduce more test failures that aren't related. @DonnchaC, @aagbsn ?

juga0 commented 6 years ago

The script and all unused code so far in branch https://github.com/TheTorProject/bwscanner/tree/feature/eliminated_code, we can recover it when basic functionality is working. Even if the extra code doesn't prevent bwscanner from working, it makes it more difficult to understand the code to beginners the extra tests takes more time. The remaining code in branch https://github.com/TheTorProject/bwscanner/tree/feature/minimal_code

juga0 commented 6 years ago

Fixed by #104