search

TheWalkers / congress-legislators

Members of the United States Congress, 1789-Present, in YAML, as well as committees, presidents, and vice presidents.
Creative Commons Zero v1.0 Universal
4 stars 6 forks source link

Geocode offices that were missing coordinates #18

Closed msimonborg closed 7 years ago

msimonborg commented 7 years ago

Came across these sort of by accident yesterday. My app geocodes any offices that are missing the coordinates and by chance I noticed these during an update

tcarobruce commented 7 years ago

Looks like these are all for locations without addresses. I'm not sure there's value in geocoding to city/zipcode centroids which aren't actually places people can go.

msimonborg commented 7 years ago

@tcarobruce That makes sense, I hadn't really noticed tbh. I was viewing them in a diff on the shell that cut off those fields, and I didn't take notice when I made the additions to the file.

I will say though that for our application there is value in having coordinates for every location even if it's a city centroid, though it's probably an uncommon use case. We sort the offices by distance to the requesting location, so that the most local offices/numbers are at the top of the list.

However, we definitely don't need to have those coordinates in the raw data, we can get by just fine geocoding the outliers on demand in our own database.

If it's not useful or even counter productive for others I'm happy to close this PR