search

TheYuriG / deno-portfolio

This is the repository that later gets rendered as my personal website.
https://www.theyurig.com
3 stars 1 forks source link

Responsive Comparison Table and README Link Fix #117

Closed spidersouris closed 1 year ago

spidersouris commented 1 year ago

Hi! Saw your post on r/learnpython yesterday and I noticed the mobile layout was a bit off so here's a quick fix. This breaks one-liners that are too long on mobile (such as BigInt(bigNumberString) in the Data Types column).

Please let me know if that works for you! I've also fixed your website's what-is-this link in the README.

TheYuriG commented 1 year ago

This looks good to me, thank you for the contribution!

I see that you didn't add your name to the contributors list in the footer (here), you can basically just copy one of the <GradientLink /> components at the bottom and change the link to your GitHub profile. I would much prefer if you were listed there as well unless you rather stay anonymous.

If it's not asking too much, would you be willing to add the same attributes to the table cells in the Retirement Table? You can find the files in /component/tools/retirement-calculator/RetirementCalculationTable.tsx, lines 96 and 100.

It's fine if you don't want to, I'll do it myself next time I'm updating the portfolio. Let me know either way and I'll merge this PR when I get a response. Much appreciated!

spidersouris commented 1 year ago

Here you go -- after some testing 20vw seems to be the optimal value for the retirement calculation table. That's a nice tool btw :)