TheoChem-VU / TCutility

Utility functions/classes for the TheoCheM programs
https://theochem-vu.github.io/TCutility/
MIT License
6 stars 0 forks source link

Issue with dependencies not being set #237

Closed YHordijk closed 6 months ago

YHordijk commented 6 months ago

I found an issue where dependencies are supposed to be set by the workflow, but they are not used when submitting it.

YHordijk commented 6 months ago

The issue seemed to be that in the dependency method we were using the conditional if otherjob.can_skip, but it is a method and not a property so it always is True. Further, this would not work if the job is currently being managed by Slurm, as then can_skip always returns True, even if it is currently running or pending. We needed to add a new method called in_queue, which checks if the job is being managed by slurm