Theopetra / theo-contracts

1 stars 0 forks source link

Post Audit Minor Issue TTC-04 | Incompatibility With Deflationary Tokens #131

Closed nflora808 closed 2 years ago

nflora808 commented 2 years ago

Issue Location: Theopetra/TheopetraTreasury.sol: 129; Theopetra/BondDepository.sol: 76; TheopetraWhitelistBondDepository.sol: 67;

Audit Issue Description

When transferring standard ERC20 deflationary tokens, the input amount may not be equal to the received amount due to the charged transaction fee. As a result, an inconsistency in the amount will occur and the transaction may fail due to the validation checks.

Auditor Recommendation

We advise the client to regulate tokens supported and add necessary mitigation mechanisms to keep track of accurate balances if there is a need to support deflationary tokens.

Billing/Time-Tracking/Access