search

ThinkInvis / RoR2-TinkersSatchel

A mod for Risk of Rain 2.
GNU General Public License v3.0
4 stars 4 forks source link

Defib clearing the HealingSourceStack causes NREs and potential crash #54

Closed svrakiss closed 2 years ago

svrakiss commented 2 years ago

Describe the Bug

Attacking enemies while you have items that heal on hit or damage creates a stutter that eventually crashes the game.

This happens even if Defib is not in the inventory. When you heal too quickly, the game stutters as the title suggests. The error appears to happen every time you heal from a hit.

To Reproduce

Steps to reproduce the behavior:

  1. Equip an item like leeching seed/defibrillator
  2. Attack and score a hit/crit on an enemy
  3. Inspect log
  4. See error

Expected Behavior

I expect to receive healing and not have the game freeze.

Console Log

Please include a link or embed of a FULL console log file from a run of the game where the bug happened. This will provide a versioned mod list, and possibly other important information about the bug.

This one crashed the game, but several hours into the run. I attacked a group of enemies. LogOutput.log

Recent: Loaded game, attacked 1 enemy then summoned and killed 2 mini bosses with rockets. LogOutput.log

Most recent: Loaded game and attacked once (3 bullets). LogOutput.log

Additional Context

ThinkInvis commented 2 years ago

This appears to be a bug with the new Old-War Lidar VFX; likely an incompatibility with another mod, as I was unable to reproduce this during testing (but nothing some extra null safety won't fix). The error with Defibrillator is a chain reaction.

ThinkInvis commented 2 years ago

Probable fix published in v2.3.3 (936a27fc584bfa1063fae3672f1d5e1d58c93e43, 11cc5a374afe681e1c91fc289adde95b3399f594). Please reopen and post a new log if the bug reoccurs (signature changed and may provide a different, more useful error).