ThirteenAG / WidescreenFixesPack

Plugins to make or improve widescreen resolutions support in games, add more features and fix bugs.
https://thirteenag.github.io/wfp
MIT License
2.34k stars 223 forks source link

NFS Undercover 1.1.2.1 (Origin/EAD) Not working #1139

Open C4J3 opened 2 years ago

C4J3 commented 2 years ago

Title says all. Game opens a command prompt (not sure if that's just me) then goes into the game normally after a few seconds but it just closes itself with the fix installed.

xan1242 commented 2 years ago

Did the older versions of the fix work before or are you just testing now?

I've made the shadow adjustments with the Steam version in mind specifically but also works with at least one more version that I know of (don't know the exact version string now).

The main common thing between them was that there wasn't any DRM involved with them, so I don't think it should work anyway...

C4J3 commented 2 years ago

Not sure about older versions of the game or fix, but I just looked and found posts with this issue from late last year. I tried the latest release and the dev build and both have this issue.

(Dev build, according to Winrar, seems to be from a couple of days ago and the latest release is from December last year. No version numbers I can see to reference.)

xan1242 commented 2 years ago

Then it's an issue with that build having DRM.

I can't say with full certainty (because I don't have that version), but what usually happens is that the DRM causes the game to shut down if there were any modifications to the executable file/active code. It could also be that certain parts of code are encrypted and the pattern detection can't find it.

You can test this out by modifying any non-volatile part of the .exe (such as some string or a part of code) and try launching it. Or maybe trying out Cheat Engine with it and nopping some instructions.

Anything that you do, it'll probably crash, whereas the DRM free builds won't.

Therefore I'm not sure if this is even fixable. (That is, your only option is to fetch a DRM free executable to work around the issue.)

ThirteenAG commented 2 years ago

Been discussed here a while ago: https://github.com/ThirteenAG/WidescreenFixesPack/issues/516

Basically I was able to somehow make partial support for this, but right now I have no idea.

I think the main reason people would want to use this version is because steam version lacks some features? Like fixed ai or something, I don't quite remember exactly.

C4J3 commented 2 years ago

I just used the version that EA Desktop downloaded. attempts with a different exe were working until I changed Shadow levels, which caused the game to crash. Now if I boot with the dll file the game is just a black screen and I can't interact. Happens with dev build and release. Also game spams an 'up' input on launch until I press down (I think it will work with any directional input, includes arrow keys as well as controller input) then I get locked out of up input completely. Doesn't work with thumbstick, D-Pad or arrow keys. Is this to do with my game version or something else?

Also would this be better in a new issue post?

Squall-Leonhart commented 1 year ago

Been discussed here a while ago: #516

Basically I was able to somehow make partial support for this, but right now I have no idea.

I think the main reason people would want to use this version is because steam version lacks some features? Like fixed ai or something, I don't quite remember exactly.

the steam edition is basically the original vanilla launch edition without any updates at all, and isn't infected by securom.

the console is basically stating that a secure module couldn't be loaded, i suspect the lack of digital signature to be the reason.

the steam release lacks challenge series, and save compatibility with the ea version.

erfansvsh commented 1 year ago

Hi there, I just wanted to inform you about that your fix makes the exact same problem which is mentioned here (game crash on cmd startup) even with the ElAmigos repack.

Honestly I don't know exactly what's DRM and what's DRM free but I just guess that it's something about cracked version maybe. If it is, so the cracked version included in ElAmigos ( https://elamigos.site/data/Need_for_Speed_Undercover__ElAmigos_-_pqcW2hVn.html ) should be a DRM-Free version.

But your fix causes crash even with ElAmigos repack.

And fortunately everyone considering you can download and test the ElAmigos repack with your fix.

Please do something for this issue...

xan1242 commented 1 year ago

ElAmigos do some things to their game distributions that we can't be certain of. I've experienced numerous issues with their builds during developing Pepega Mod.

As this game was unlisted recently, I'll send the exact build of the game exe as soon as I can. (It's the Steam build of the game basically)

There is no working around some of these issues, so it's better to take one or two compatible builds and roll with them.

xan1242 commented 1 year ago

nfs_steam.zip

You can use this executable to run the game in the most stable fashion.

Squall-Leonhart commented 1 year ago

downgrade to 1.0.1.17 to mitigate this.

xan1242 commented 1 year ago

I don't think you need to downgrade the entire game, executable swapping should be enough.

Squall-Leonhart commented 1 year ago

1.0.1.18 has other issues besides the binary module check, like low framerates.

xan1242 commented 1 year ago

This all being said, I don't think it's reasonable to support the DRM scrambled versions.

We've already incorporated pattern detection, albeit jankily in some areas, but nonetheless they're there.

The only other idea I have is to, well, disable the portions of code until the DRM builds start working again.

But, in my opinion, it is too much work for this game, which is perfectly operable by using the executable I provided above.

So, if everyone have no objections, I'd consider this case closed.

People should really just use the Steam build and that's it.

Challenge Series, while a bit of a loss, isn't anything to write home about, and could very well be restored with a separate mod.

Squall-Leonhart commented 1 year ago

You get Challenge Series with 1.0.1.17 and it can be applied on top of Steam, it doesn't have the low framerate issue and it supports mods and specialK for forcing waitable swapchain.

erfansvsh commented 1 year ago

I'm back again to tell you the results.

First of all, thanks for your quick response this time! (Because unfortunately on the other thread which is about NFS Hot Pursuit 2 still you haven't answered for two weeks now 😅 https://github.com/xan1242/hp2wsfix/issues/19 ).

Secondly, thanks for your provided exe file which eliminated the crash problem.

However that I wonder why the exe file from ElAmigos repack is about 44MB in size and yours is only 10MB which absolutely made me think twice about whole the story here 😅😅

It worth mention that I had a couple of performance issues with your fix. My GPU is an Nvidia GeForce GT 730 and I was able to run the ElAmigos repack at 1080p with a constant frame rate of 60 frames per second. But after applying your fix, it dropped under 30fps constantly 😅... Therefor I had to check your ini config file in order to reduce your default values of CSMScaleNear and CSMScaleMid and CSMScaleFar also SimRate to their original game default values and my fps got back to constant 60fps! Actually I got two PCs in home, one of them is for old school games like NFS Undercover (Undercover 2008 is considered very modern in my list when I say old school 😅) and uses less power (think about my bills at the end of month 🙈) but the other machine which is sported with a RTX 3080 and 32GB of RAM is for Cyberpunk stuff, and your fix made me to install Undercover on that RTX option 😂😂 (I never thought that I'll have to do such thing one day!)

But about that Challenge Series stuff which I wasn't aware of all of it until you mentioned 🤣 Honestly you yourself made me curious to go and watch a couple of gameplay videos for this Challenge Series. Then my sense of greedy came up and I tried to install it via the NFSU_v1.0.1.18_enUS.exe installer which I downloaded from NFS Planet at https://www.nfsplanet.com/nfsuc_patch.php?lang=eng It was simply unsuccessful. I faced with an error "Old File not found". So I simply gave it up!

Unfortunately I didn't get what did you mean of this: "You get Challenge Series with 1.0.1.17 and it can be applied on top of Steam, it doesn't have the low framerate issue and it supports mods and specialK for forcing waitable swapchain."

Do you mean that we can install Challenge Series patch on v1.0.1.17 too? This is the same version as ElAmigo repack is. If yes, where is the installation file though?

By the way I should mention that main reason for me to use your fix is just the ImproveGamepadSupport stuff honestly which gives me the feel of PlayStation 3 of old times when I was younger playing this game on that console...

Is there any way for you to give me a file which doesn't change anything but only include this ImproveGamepadSupport option?

At the end, when I was playing the PS3 version I can remember that in Garage section of this game (Cars in Pause Menu) I could see a very beautiful reflection on the ground that was reflecting the vertical light bar (of the garage door light leak maybe). Unfortunately I was never able to see such thing in PC version even when I change the registry file through _[Computer\HKEY_CLASSESROOT\VirtualStore\MACHINE\SOFTWARE\WOW6432Node\EA Games\Need for Speed Undercover] regeditor. I change the default value of 0 to 1 for "_gRoadReflectionEnable" class, but with no luck...

Thanks for everything you do to keep these masterpiece games alive! 🌹

xan1242 commented 1 year ago

First of all, thanks for your quick response this time! (Because unfortunately on the other thread which is about NFS Hot Pursuit 2 still you haven't answered for two weeks now 😅 xan1242/hp2wsfix#19 ).

Sorry, busy with other projects, not keeping track in certain periods can lead to that...

erfansvsh commented 1 year ago

First of all, thanks for your quick response this time! (Because unfortunately on the other thread which is about NFS Hot Pursuit 2 still you haven't answered for two weeks now 😅 xan1242/hp2wsfix#19 ).

Sorry, busy with other projects, not keeping track in certain periods can lead to that...

OK now please read whole my message not the first paragraph only 😅

longaru commented 1 year ago

Dunno why U use this "elamigo" repack ( since 5.2.2014 ) , it's simply old buggy 43.5 mb & 1017 version with optimization bugs ( 1 CPU thread have 100% usage etc ) And also ExtraOptions doesn`t works .

For Me now : Steam 1001 ( 1 Build ) , Origin 1121 ( 3 Builds ) – works fine . 1017 – no , and I don`t use it .