fixed bug in Gerber Library (MultiMerge function) that corrupts output.

ThisIsNotRocketScience / GerberTools

Tools to load/edit/create/panelizer sets of gerber files

MIT License

726 stars 145 forks source link

fixed bug in Gerber Library (MultiMerge function) that corrupts output. #47

Closed Vitalhb closed 6 years ago

Vitalhb commented 6 years ago

GS.Split(GCC.originalline, File1Parsed.State.CoordinateFormat) was called two times in several places. That causes corruption on Gerber command lines like this: G01G01X000500Y001000D02X000500Y001000D02*

Only changes in file GerberMerge.cs are significant. Other changes can be discarded.

deece commented 6 years ago

Wow, that patch is really hard to review, which may be one reason why it hasn't been merged.

It seems this was fixed by commit c5b5c1f9db4e2861e470f895cf371e7ca1768833, so this PR could probably be closed.

deece commented 6 years ago

@StijnKuipers This can be closed