Thom1729 / Sublime-JS-Custom

Customizable JavaScript syntax highlighting for Sublime Text.
MIT License
137 stars 9 forks source link

Update for next Sublime version #91

Closed Thom1729 closed 3 years ago

Thom1729 commented 4 years ago

Sublime dev builds offer new highlighting features, and new versions of the core JavaScript syntax use those features (and provide better highlighting as a result). At some point, JS Custom will update to use the new core syntax. This will be a breaking change; it will only be compatible with future Sublime versions.

The next version should:

The current major version:

Thom1729 commented 4 years ago

For anyone watching this, my current plan is to release v2.4 for current versions of Sublime with beta-quality TypeScript support (see #51). There probably won't be a v2.5, and v3 will require a newer version of Sublime. This plan may change.

Thom1729 commented 3 years ago

v2.4 has been out for some time with experimental TypeScript support. It's based on the most recent ST3-compatible core syntax and will most likely not receive any updates except for critical bug fixes.

v3.0 is in alpha, but it's probably ready for beta. It features the latest core improvements, taking full advantage of the new features of ST4. TypeScript support is greatly improved over v2.4 (it should be identical to the new core TypeScript syntax). Most likely, only v3.0 and further will get new features.

If you're on the ST4 beta, you can get the latest JS Custom 3.0 alpha by adding "install_prereleases": ["JSCustom"] to your Package Control config.

isubasti commented 3 years ago

I can't seem to find JSCustom on ST4 beta's packages. looks like it's related to https://github.com/wbond/package_control/issues/1557

Thom1729 commented 3 years ago

@isubasti I suspect the problem was actually that I set up the new ST4 tags incorrectly in the Package Control channel. I've just officially released v3.0.0 — please let me know if you can install it! (It may take a couple of hours for Package Control to pick it up.)

michaelblyons commented 3 years ago

Package Control sees the v3 release, but it's still tagged as needing review. You might have to ping Will (or FF?) to clear the Needs Review flag.

If the problem genuinely started with misconfigured tags, that's a great big footgun to watch out for.

Thom1729 commented 3 years ago

How can I see that the Needs Review flag is set?

michaelblyons commented 3 years ago

On the PC page, you'll see "NEEDS REVIEW" with a little yellow ⓘ, next to "by Thom1729"

Edit: I meant to screenshot in the previous message, but I must have forgotten (and the review message is gone now).

wbond commented 3 years ago

I cleared the review flag earlier today.

Thom1729 commented 3 years ago

Thanks for the fix!

Thom1729 commented 3 years ago

@isubasti Is it working for you now?

isubasti commented 3 years ago

@Thom1729 It is indeed working now

Thom1729 commented 3 years ago

Since the tags for v3 got messed up, and we ended up with an ST3-compatible v3, I just bumped the ST4 stuff to v4. It's out and stable, so I'm closing.