ThomasTavernier / Improve-Crunchyroll

MIT License
41 stars 10 forks source link

Subtitles in any language #16

Open thiagokuhn opened 1 year ago

thiagokuhn commented 1 year ago

Hi!

I like watching anime with English dub and subtitles in my native language. Unfortunately, CR only allows me to choose a subtitle language if the audio is in Japanese. If I change the audio to English, it only lets me choose English subtitles.

Would it be possible to implement a system allowing to choose any subtitle language independently from the audio language?

Thanks.

ThomasTavernier commented 3 months ago

Thanks for your feedback! I've already discussed this with someone and took a look at it. Unfortunately, integrating such a system without additional unwanted permissions didn't seem easily feasible. However, despite expressing interest in involving a developer for a potential pull request, I haven't received any further communication from them. Unfortunately, I currently don't have the time to handle it myself. Appreciate your understanding!

bytedream commented 3 months ago

I don't know what you talked about with this person @ThomasTavernier sou maybe you're already aware of what I'm about to say. It's often the case that the video length of different audios aren't the same. For example the first episode of Darling in the Franxx is 24 minutes long with japanese audio, but only 23 minutes and 58 seconds long with german audio. So loading the german subtitle that belongs to the japanese audio into the german video will cause the subtitle to be out of sync with the audio.