search

Thrilleratplay / coreboot-builder-scripts

Bash scripts and config files to simplify building of Coreboot using the official coreboot-sdk docker image
GNU General Public License v3.0
32 stars 9 forks source link

Support for Thinkpad T420 #14

Open qiyunluoxing opened 3 years ago

qiyunluoxing commented 3 years ago

Is it possible to add Thinkpad T420 support? I have dumped the factory firmware of Thinkpad T420 and flashed coreboot. I am happy to assist with testing.

Thrilleratplay commented 3 years ago

If it has Intel video, adding a T420 should be trivial. The only reason I do not have it included is because I do not own one to verify it works when a new version of coreboot is released. It isn't that I do not want to support it, I do not want to accidentally leave someone with device that does not boot correctly. It is very unlikely as the T420 with Intel video is almost identical to the X220 config,

Looking at the forks, it seems like someone already created the T420 along with bootsplash. https://github.com/MarieKirya/coreboot-builder-scripts/tree/add-t420-support

qiyunluoxing commented 3 years ago

Thank you for your advice.

szarpaj commented 3 years ago

I can test. Let's make this a real thing. :)

Thrilleratplay commented 3 years ago

@szarpaj You are welcome to create a pull request. If you copy the x220 directory and change the device to be t420 that may be enough. If you do this, please remove any defconfig versions you did not test.

My only issue with the above fork is that is uses the VGA blob. I want to keep the devices as close to one another as possible and if there is an issue with this device, I do not have a T420 to debug the problem.