ThugDev / PurrTunes

๊ณ ์–‘์ด๊ฐ€ ํ‹€์–ด์ฃผ๋Š” ๋žœ๋ค ์Œ์•… ์žฌ์ƒ ์‚ฌ์ดํŠธ
https://purr-tunes.vercel.app/
0 stars 2 forks source link

set design token & publish layout #7

Closed 55555-Jyeon closed 3 months ago

55555-Jyeon commented 3 months ago

๊ฐœ์š”


PR Checklist

PR์ด ๋‹ค์Œ ์š”๊ตฌ ์‚ฌํ•ญ์„ ์ถฉ์กฑํ•˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.


PR details

๐ŸŽ styles: apply design token(font & colors)

๋””์ž์ธ ์‹œ ์‚ฌ์šฉํ–ˆ๋˜ ํฐํŠธ(Noto Sans KR) ๋ฐ ์ƒ‰์ƒ ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค. ์ƒ‰์ƒ ์ด๋ฆ„์€ ์•„๋ž˜ ํ™•์ธ ํ›„ ์‚ฌ์šฉํ•ด์ฃผ์„ธ์š” ๐Ÿ™‚

colors


๐ŸŽ style: seperate flex styles

flex์™€ ๊ด€๋ จ๋œ ์ •๋ ฌ ์Šคํƒ€์ผ์€ ์ž์ฃผ ์“ฐ์ผ ๊ฒƒ ๊ฐ™์•„์„œ ๋”ฐ๋กœ ๋ถ„๋ฆฌํ•ด๋‘์—ˆ์Šต๋‹ˆ๋‹ค. ๐Ÿ“‚ global.css ํŒŒ์ผ ์•ˆ์— ๊ฐ€์šด๋ฐ ์ •๋ ฌ ๊ด€๋ จํ•ด์„œ๋งŒ ์šฐ์„  ์ถ”๊ฐ€ํ•ด๋‘์—ˆ์–ด์š”.

์ž์ฃผ ์“ฐ์ผ ์ •๋ ฌ๊ณผ ๊ด€๋ จ๋œ ์Šคํƒ€์ผ์€ ์•„๋ž˜์™€ ๊ฐ™์ด ๋ถ„๋ฆฌํ•ด์„œ ์‚ฌ์šฉํ•˜๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š” :)

/* aligns */
.flex-center {
    @apply flex justify-center items-center;
}
.flex-items {
  @apply flex items-center;
}
.flex-justify {
  @apply flex justify-center;
}


git issue์—๋„ ์ถ”๊ฐ€ํ•ด๋‘์—ˆ๋Š”๋ฐ glass-morphsim์€ ๊ฐ™์€ ์Šคํƒ€์ผ์ด ์ ์šฉ๋˜๋Š” ๋ถ€๋ถ„์ด ๋งŽ์œผ๋ฏ€๋กœ tailwind.config.ts์— ๋ถ„๋ฆฌํ•ด์„œ ์‚ฌ์šฉํ•˜๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”.

header์— ์ ์šฉ๋  glass-effect๋Š” ์‚ฌ์‹ค ๋”๋Ÿฌ ์“ฐ์ด๋Š” ๋ถ€๋ถ„์€ ์•„๋‹ˆ์ง€๋งŒ tailwind๋กœ ์ž‘์„ฑ์‹œ ๋„ˆ๋ฌด ๊ธธ์–ด์ ธ์„œ ์ƒ˜ํ”Œ ์‚ผ์•„ ๋ถ„๋ฆฌํ–ˆ์Šต๋‹ˆ๋‹ค. modal์— ์ ์šฉ๋˜๋Š” ์Šคํƒ€์ผ์€ ์ „๋ถ€ ๋™์ผํ•˜๋ฏ€๋กœ ๋ณ„๋„์˜ ํด๋ผ์Šค(class)๋กœ ๋ถ„๋ฆฌํ•ด์„œ ์‚ฌ์šฉํ•˜๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”.

plugins: [
        plugin(function ({ addUtilities }: PluginAPI) {
            const newUtilities = {
                ".header-glass-effect": {
                    background: "rgba(255, 255, 255, 0.1)",
                    borderRadius: "16px",
                    boxShadow: "0 4px 30px rgba(0, 0, 0, 0.1)",
                    backdropFilter: "blur(9px)",
                    WebkitBackdropFilter: "blur(9px)",
                    border: "1px solid rgba(255, 255, 255, 0.3)",
                },
            }
            addUtilities(newUtilities)
        }),
    ],


๐ŸŽ style: publishing layout and header
๐ŸŽ style: complete publishing footer

๋ ˆ์ด์•„์›ƒ ํผ๋ธ”๋ฆฌ์‹ฑ ์™„๋ฃŒํ–ˆ์Šต๋‹ˆ๋‹ค. footer๋Š” ๋””์ž์ธ์€ ๋˜์–ด ์žˆ์ง€ ์•Š์ง€๋งŒ ์ž„์˜๋กœ ๊ธฐ๋ณธ์ ์ธ ๋‚ด์šฉ๋งŒ ๋„ฃ์–ด๋‘์—ˆ์–ด์š”!

layout


๐ŸŽ style: change favicon and logo

logo์˜ ํ™”์งˆ์ด ์ข€ ๋–จ์–ด์ง€๋Š” ๊ฒƒ ๊ฐ™์•„ ์‚ฌ์ด์ฆˆ๊ฐ€ ํฐ ๊ฑธ๋กœ ๋ณ€๊ฒฝํ–ˆ๊ณ  favicon ๋ฐ metaData ๋‚ด์šฉ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค. favicon์€ ์•„๋ž˜ ์‚ฌ์ง„์—์„œ ํ™•์ธ ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.

change favicon


๐Ÿ‘ฉ๐Ÿปโ€๐Ÿ’ป ๋‚˜๋ˆ„๊ณ  ์‹ถ์€ ์˜๊ฒฌ ์žˆ์–ด์š”

์ด์ „ ํ”„๋กœ์ ํŠธ์—์„œ ๊ด€๋ฆฌํ•˜๋˜ ํด๋”๋“ค(์ „์—ญ์œผ๋กœ ๊ด€๋ฆฌํ•ด์•ผ ํ•˜๋Š” ํด๋”๋“ค)์„ ์ด๋ฒˆ์—๋Š” app ๋‚ด๋ถ€์— ๋„ฃ๊ธฐ๋กœ ํ–ˆ์ž–์Šต๋‹ˆ๊นŒ. ํด๋” ์•ž์— ์–ธ๋”์Šค์ฝ”์–ด()๊ฐ€ ๋ถ™์€ ํด๋”๋“ค์ด ์ข€ ๋งŽ์€ ๊ฒƒ ๊ฐ™์€๋ฐ ํ˜น์‹œ ์ตœ์ƒ์œ„๋กœ ์–ธ๋”์Šค์ฝ”์–ด()ํด๋”๋ฅผ ์ƒ์„ฑ ํ›„ ๊ทธ ์•ˆ์— ์ „์—ญ์œผ๋กœ ๊ด€๋ฆฌ ๋ผ์•ผ ํ•˜๋Š” ํด๋”๋“ค์„ ๋„ฃ์–ด ๊ด€๋ฆฌํ•˜๋Š” ๊ฑด ์–ด๋–ค๊ฐ€์š”..?

current folder structure
suggestion
app/_/components
app/_/hooks
...


์•„๋‹ˆ๋ฉด ์•„๋ž˜์ฒ˜๋Ÿผ ๊ทธ๋ฃน์œผ๋กœ ๋‚˜๋ˆ  ๊ด€๋ฆฌํ•  ์ˆ˜๋„ ์žˆ์„ ๊ฒƒ ๊ฐ™์•„์š”.


ํด๋” ๊ตฌ์กฐ ํ˜น์‹œ ๋ณ€๊ฒฝ๋˜๊ฒŒ ๋˜๋ฉด ๋ฉ”์ธํŽ˜์ด์ง€ ํผ๋ธ”๋ฆฌ์‹ฑ ๊ด€๋ จํ•ด์„œ ๋ธŒ๋žœ์น˜ ์ƒ์„ฑํ•ด ์ง„ํ–‰ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค! ๐Ÿ˜ฌ


When modifying code...

# Request Level
  - [ ] : "๐Ÿ”ฅ ์ด๊ฑธ PR์ด๋ผ๊ณ  ์˜ฌ๋ ธ์–ด์š”? ๋‹น์žฅ ์ˆ˜์ •ํ•ด์ฃผ์‹œ์ฃ !?"
  - [ ] : "๐Ÿฅน ์ด๊ฑด ์ข€..."
  - [ ] : "๐Ÿคท PRํ•˜๊ธฐ ์ „์— ์ƒ๊ฐํ–ˆ๋‚˜์š”?"

# Description
55555-Jyeon commented 3 months ago

ํด๋” ๋‚˜๋ˆ„๋Š”๊ฑฐ ์ข‹์€ ์•„์ด๋””์–ด ๊ฐ™์Šต๋‹ˆ๋‹ค..!

์–ด๋–ป๊ฒŒ ๋‚˜๋ˆŒ๊นŒ์š”..?! ๐Ÿ˜ฎ

  1. ์–ธ๋”์Šค์ฝ”์–ด(_)๋กœ ์ „์—ญ ๊ด€๋ฆฌํ•ด์•ผ ํ•˜๋Š” ํด๋”๋“ค๋งŒ ๋ณ„๋„๋กœ ๊ด€๋ฆฌ
  2. ๊ด„ํ˜ธ๋กœ ์ „์—ญ ๊ด€๋ฆฌํ•ด์•ผ ํ•˜๋Š” ํด๋”๋“ค ๋ฐ ํŽ˜์ด์ง€๋“ค ๊ฐ๊ฐ ๊ทธ๋ฃน์œผ๋กœ ๊ด€๋ฆฌ
ijimlnosk commented 3 months ago
  1. ์–ธ๋”์Šค์ฝ”์–ด(_)๋กœ ์ „์—ญ ๊ด€๋ฆฌํ•ด์•ผ ํ•˜๋Š” ํด๋”๋“ค๋งŒ ๋ณ„๋„๋กœ ๊ด€๋ฆฌ
  2. ๊ด„ํ˜ธ๋กœ ์ „์—ญ ๊ด€๋ฆฌํ•ด์•ผ ํ•˜๋Š” ํด๋”๋“ค ๋ฐ ํŽ˜์ด์ง€๋“ค ๊ฐ๊ฐ ๊ทธ๋ฃน์œผ๋กœ ๊ด€๋ฆฌ

์Œ...1๋ฒˆ์ด ์–ด๋–จ๊นŒ์š”?

55555-Jyeon commented 3 months ago

์Œ...1๋ฒˆ์ด ์–ด๋–จ๊นŒ์š”?

๐Ÿ”– rename: change folder structure

๋„ต! ์–ธ๋”์Šค์ฝ”์–ด(_)๋กœ ๋ณ€๊ฒฝํ•ด์„œ ์ปค๋ฐ‹ํ–ˆ์Šต๋‹ˆ๋‹ค!


import ๊ฒฝ๋กœ๋Š” ์•„๋ž˜์™€ ๊ฐ™์ด ๋ณด์—ฌ์ง€๊ฒŒ ๋ฉ๋‹ˆ๋‹ค!

ijimlnosk commented 3 months ago

๋„ต! ์–ธ๋”์Šค์ฝ”์–ด(_)๋กœ ๋ณ€๊ฒฝํ•ด์„œ ์ปค๋ฐ‹ํ–ˆ์Šต๋‹ˆ๋‹ค!

์•„์ฃผ์ข‹์Šต๋‹ˆ๋‹ค!