TianyiShi2001 / audiotags

Unified IO for different types of audio metadata
https://tianyishi2001.github.io/audiotags
MIT License
41 stars 29 forks source link

Fix incorrect access to track fields on disc getters #26

Closed cdown closed 1 year ago

cdown commented 1 year ago

Tagging @pinkforest and @Serial-ATA -- am I missing something here or is this a bug?

Also any thoughts on #27 and #28?

Thanks, and sorry to bother!

Serial-ATA commented 1 year ago

You're not missing anything, I just don't have the ability to merge this. :smile:

pinkforest commented 1 year ago

This will be a breaking change for 0.5 - @Serial-ATA I assume we can merge this ?

Looks like we need to fix clippy as well

Serial-ATA commented 1 year ago

Yeah, this is good to merge. The clippy fix is in #28

cdown commented 1 year ago

Thanks! Appreciate you both looking over the changes.