search

TianyiShi2001 / audiotags

Unified IO for different types of audio metadata
https://tianyishi2001.github.io/audiotags
MIT License
41 stars 29 forks source link

copy album artist to album artist #29

Closed microtonez closed 1 year ago

microtonez commented 1 year ago

Hello,

I hope that this PR finds you well. Thanks for this nice library.

I noticed that the album artist string appears to get copied to the artist, rather than the album artist when dyn tags are used. I believe I have corrected the issue. I tried the supplied test with and without the change and it appears to fail without the changes. Do you think this would make sense to change?

Thanks

microtonez commented 1 year ago

Hi @TianyiShi2001

Have you had a chance to review the PR yet? It would be great to get this merged if it's looking good.

Thanks

Serial-ATA commented 1 year ago

@pinkforest This looks good to merge if you're interested.

pinkforest commented 1 year ago

Hey thanks for taking time to chase these both of you