search

TianyiShi2001 / audiotags

Unified IO for different types of audio metadata
https://tianyishi2001.github.io/audiotags
MIT License
41 stars 29 forks source link

Feat/add full date capabilities #34

Closed BSteffaniak closed 9 months ago

BSteffaniak commented 11 months ago

Hi! Thank you for making this crate!

I noticed that there didn't seem to be a way to get the full date from a tag, only a year i32. The tags across flac/id3/mp4 all seem to support a full date in some sort of way, but it doesn't seem to be standard across them. The id3 library seems to be the most specific with how it handles the dates, so for this PR I initially went with specifying the dates with the most specificity across the formats, rather than attempting to keep it at the lowest common denominator (like it seems you might be trying to do). I also just reused the id3::Timestamp, which you might not find desirable, but I could change that to something more standard, if you have something in mind.

Also, forgive my ignorance on the audio specs. I'm not very familiar with them, so if this all seems like an anti-pattern, please let me know.

Thanks!

Serial-ATA commented 11 months ago

@pinkforest Pinging so this is on your radar. Should be good to merge after the last comment is addressed.

pinkforest commented 9 months ago

Just checking quick - Is this PR kosher - there seems to be open conversations ? Thx you both

Serial-ATA commented 9 months ago

Yep, this is good. All comments were addressed.