Add ability to set default attribute filters

TileDB-Inc / TileDB-CF-Py

TileDB interface with awareness of the CF metadata conventions

https://tiledb-inc.github.io/TileDB-CF-Py/

MIT License

19 stars 3 forks source link

Add ability to set default attribute filters #101

Closed jp-dark closed 3 years ago

jp-dark commented 3 years ago

Adds default attribute filters to ArrayCreator and subclasses
Adds default filter for dims, attrs, and offsets to from_netcdf and from_group

shortcut-integration[bot] commented 3 years ago

This pull request has been linked to Shortcut Story #10602: Add default filters for attributes.

nguyenv commented 3 years ago

Using level=None in TileDB-Py internally sets the TILEDB_COMPRESSION_LEVEL to -1 which in turn uses the compressor-specific default. For zstd, the default level is 3.

nguyenv commented 3 years ago

To update my previous comment, core is setting the level for zstd to 5 here.

However it states ZSTD_CLEVEL_DEFAULT==3 in the zstd docs, so I am going to ask about the discrepancy.

In any case, we are applying compression internally even with level=None in TileDB-Py.