search

TileDB-Inc / TileDB-R

R interface to TileDB: The Modern Database
https://tiledb-inc.github.io/TileDB-R
Other
103 stars 18 forks source link

Update for linux-aarch64 #707

Closed johnkerl closed 4 months ago

johnkerl commented 6 months ago

The inst/tinytest/test_timetravel.R file fails its last few cases in Conda feedstock CI for target_platform linux-aarch64:

https://github.com/conda-forge/r-tiledb-feedstock/pull/78

...

test_timetravel.R.............   27 tests OK 
test_timetravel.R.............   27 tests OK 
test_timetravel.R.............   27 tests OK 
test_timetravel.R.............   28 tests OK 
test_timetravel.R.............   28 tests OK 
test_timetravel.R.............   29 tests 1 fails 
test_timetravel.R.............   29 tests 1 fails 
test_timetravel.R.............   30 tests 1 fails 
test_timetravel.R.............   30 tests 1 fails 
test_timetravel.R.............   31 tests 1 fails 5.8s

test_vfs.R....................    0 tests    
test_vfs.R....................    0 tests    
test_vfs.R....................    0 tests    
test_vfs.R....................    0 tests    
test_vfs.R....................    1 tests OK 
test_vfs.R....................    1 tests OK 
test_vfs.R....................    1 tests OK 
...

https://github.com/conda-forge/r-tiledb-feedstock/pull/78#issuecomment-2105312954

eddelbuettel commented 4 months ago

This never had anything to do with aarch64 per se, it was simple a test that was seen in some circumstances as fragile.

In any event, it was rewritten for 0.28.0.

johnkerl commented 4 months ago

Thanks @eddelbuettel for fixing an issue which was experienced in Conda feedstock CI for target_platform linux-aarch64!

eddelbuettel commented 4 months ago

I also had once or twice on (iirc) windows tests. Not often enough to be a royal pain but often enough (with this) to be worth addressing.