Timberborn-Modding-Central / TimberAPI

The one and only
https://timberapi.com
GNU General Public License v3.0
32 stars 18 forks source link

fix crashes in case of same localization record id edited #85

Closed scorsi closed 10 months ago

scorsi commented 10 months ago

The thing I noticed for now are only the short name (r, g, enumeration) these should be changed to the meaningfull names.

I've done the change, imo I feel short-range variables much more readable when short-written :)

Ex: records.Select(r => r.Id); we know that r is record we don't have to go far back in the code to understand what the variable means and the action of the lambda is clearer we directly see that we're extracting Id field. But opinion 👍

KYPremco commented 10 months ago

Works good, very nice.