search

TimeForANinja / node-ytpl

Anonymous YouTube playlist resolver.
MIT License
203 stars 48 forks source link

Update URL API #111

Closed Progitiel closed 3 years ago

Progitiel commented 3 years ago

Move from deprecated Legacy API to WHATWG URL API. https://nodejs.org/api/url.html#url_legacy_url_api

codecov[bot] commented 3 years ago

Codecov Report

Merging #111 (a0ebedb) into master (0ecef92) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #111   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          255       259    +4     
=========================================
+ Hits           255       259    +4
Impacted Files Coverage Δ
lib/parseItem.js 100.00% <ø> (ø)
lib/utils.js 100.00% <ø> (ø)
lib/main.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ecef92...a0ebedb. Read the comment docs.

Progitiel commented 3 years ago

I agree. With this goal in mind, the two .startsWith('RD') don't need to be added.

TimeForANinja commented 3 years ago

👍 Thanks again for this PR gonna push to npm in a sec