search

TimonKK / clickhouse

NodeJS client for ClickHouse
Apache License 2.0
220 stars 122 forks source link

uuid@3.4.0: Please upgrade to version 7 or higher. #139

Open vfilatov opened 1 year ago

vfilatov commented 1 year ago

There are three outdated packages in dependencies.

  1. WARN  deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
  2. WARN  deprecated request@2.88.0: request has been deprecated, see https://github.com/request/request/issues/3142
  3. WARN  deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

Would it be possible to update the dependencies?

francescorivola commented 1 year ago

I would consider remove uuid package dependency in favor of node.js crypto randomUUID (see https://nodejs.org/api/crypto.html#cryptorandomuuidoptions). It is in node.js since node.js 14. In case this option is chosen I would suggest to bump the library to a major version because it would drop support to node.js 12 (this version of the runtime already reached its ends of life). Thank you.