search

TimothyLuke / GSE-Advanced-Macro-Compiler

GSE is an alternative advanced macro editor and engine for World of Warcraft.
https://discord.gg/gseunited
MIT License
218 stars 74 forks source link

[BUG] Beast Master Spec. Concussion Shot #1659

Closed Silicon14asp closed 2 months ago

Silicon14asp commented 2 months ago

🔵 Describe the bug: A clear and concise description of what the bug is.

When creating new sequence, selecting Concussion Shot, in Spell box in first block.

🔵 To reproduce: (Steps to reproduce the behavior) /gse Select Spell type in "Concussion Shot" Save

🔵 The error: Paste the error message in this blockquote. MacroName was unable to be programmed. This macro will not fire until error is corrected.

🔵 Screenshots: If applicable, add screenshots to help explain your problem.

🔵 Expected behavior: Concussion Shot to fire off and not be renamed Wing Clip, when added into the sequences.

🔵 GSE.lua file: GSE.lua.txt

🔵 Desktop (please complete the following information):

🔵 GSE Version:

🔵 Additional context: nope

TimothyLuke commented 2 months ago

Concussive Shot to fire off and not be renamed Wing Clip, when added into the sequences.

Wing Clip is the base spell for Concussive Shot - This is expected see https://github.com/TimothyLuke/GSE-Advanced-Macro-Compiler/wiki/Base-Spells

I am also unable to replicate your issue with the spell block. Did you enter a valid unit name?

image

TimothyLuke commented 2 months ago

Using the sequence on the dummy:

image

dudMbaGliuBdiAMajZwOBkb)sc9nGWoLQ9s2nL(jqXWuQFtvdecz4aoiu50u5yi5CqvleOQLcuAXuKLlLhcLEkQLHuph0erKPkyYsY0vDriXvbsDzrxxjFgH2kezZqkBNI6JqqFfcmniQhtHrkr16aQmAj1RHKojI6WkUgcopu8jjkpds1TLilkfuNsCiHhR3ASGqN5KR9xDAfexymAEOcQtPGyCg35TqfuNsbXhdqkgcKXO4agGumoJ78wXqGmgvNcpbqImbXlR7I)0iMxxxmzRPLlEKMMBmftOc666IrqoOIB1gOc6Ib1apObQMNvIP30iVXtdInEc0B8IlKFinFuqC5zei6SOkU(hacUIfRCqdFRcXejwKimxw3ZkX4wV23etoIj)reP51Lb2S00eJqgfKYg05TQJo9ElUWyxtKS9zZCAVZBLjXKs0Mv8QtjUpLsXHeESERXccDMtU2FXmqAqMK60eqxCamyvNIAV30IrXIMVzKy9LaMpMCr3XiWRRRlb
TimothyLuke commented 2 months ago

Current version of GSE is also 3.2.14-e so you may need to update

Silicon14asp commented 2 months ago

Timothy,

Here is a video that shows cases the issue.

https://youtu.be/0QvTkIvAjMM YouTubehttps://youtu.be/0QvTkIvAjMM Share your videos with friends, family, and the world youtu.be

From: Timothy Minahan @.> Sent: Thursday, September 26, 2024 6:23 PM To: TimothyLuke/GSE-Advanced-Macro-Compiler @.> Cc: Silicon14asp @.>; Author @.> Subject: Re: [TimothyLuke/GSE-Advanced-Macro-Compiler] [BUG] Beast Master Spec. Concussion Shot (Issue #1659)

Concussive Shot to fire off and not be renamed Wing Clip, when added into the sequences.

Wing Clip is the base spell for Concussive Shot - This is expected see https://github.com/TimothyLuke/GSE-Advanced-Macro-Compiler/wiki/Base-Spells

I am also unable to replicate your issue with the spell block. Did you enter a valid unit name?

image.png (view on web)https://github.com/user-attachments/assets/72160783-2d2b-42c3-9792-382b7c987086

— Reply to this email directly, view it on GitHubhttps://github.com/TimothyLuke/GSE-Advanced-Macro-Compiler/issues/1659#issuecomment-2378170142, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A32LZUJZC7JWGOAVF5ZD2QLZYSQQVAVCNFSM6AAAAABO6COW7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYGE3TAMJUGI. You are receiving this because you authored the thread.Message ID: @.***>

TimothyLuke commented 2 months ago

I watched your video - Read the link on Base Spells it will explain what is happening with Concussive Shot and Wing Clip. Its actually not a bug. When you /cast Wing Clip wow actually casts Concussive Shot as a hunter. It was survival but its part of what happened when they base lined it. On that page are three commands - run them and you will get the same result.

All hunters start as Survival and Marksmanship and Beast Master are overlaid on top now. The bit about Base Spells has been happening since Legion.