Add Korean

[VenusGirl]

Yes, ask me anything...

[Timthreetwelve]

Thanks. When I check a new language one of the things that I look for is to see that none of the phrases are cut truncated or otherwise displayed incorrectly. I didn't notice any, and Korean phrases generally appear to be shorter than English, so I don't anticipate any.

In the screenshot below, the word "Get" appears missing (in the green box). Or am I misinterpreting? The resource string in English is <sys:String x:Key="About_Update">Update Get My IP</sys:String>.

Also, could you verify that I have attributed your contribution correctly (in the blue box).

I'll look at the Inno Setup updates tomorrow, it's getting late here. 😴

Thanks again, Tim

[VenusGirl]

I added the missing "Get" with the green mark The name of the contributor in the blue mark is correct: English (Korean) The language name is written in English, but is it automatically translated because the country (language) code is applied? Language name: Should I delete (ko-KR) from Korean (ko-KR)? Do I have to write only one contributor's name?

[Timthreetwelve]

@VenusGirl, the language names that can be seen in the list at the bottom of the About page and in the dropdown in the Language section of the Settings page come from a class that I called UILanguage. If you scroll down, you can see that there is a list called LanguageList. The language displayed comes from the LanguageNative property. I look up the NativeName property in System.Globalization.CultureInfo.GetCultures to get the spelling for LanguageNativeand then ask if that looks correct.

LanguageList is then sorted by the LanguageCode and becomes the source lists seen on the Settings and About pages.

So, the language name and code in the comments of the language file aren't what are displayed in the app but serve as documentation and as a starting point for me when a language is contributed.

That's probably more than you wanted to know; I hope that it answered your questions.

Thanks for your update.

Tim

[VenusGirl]

OK! I understand. Thank you for your kind detailed response. I modified it to display like a list of other languages. 한국어 (대한민국) -> 한국어