Timvde / UserChrome-Tweaks

A community maintained repository of userChrome.css tweaks for Firefox
GNU General Public License v3.0
1.25k stars 122 forks source link

working version of auto-hide.css for Firefox 72 #160

Closed sans-c closed 4 years ago

sans-c commented 4 years ago

Fixes https://github.com/Timvde/UserChrome-Tweaks/issues/157, might fix https://github.com/Timvde/UserChrome-Tweaks/issues/152 and https://github.com/Timvde/UserChrome-Tweaks/issues/150 as well. This version DOES NOT hide the bookmarks toolbar.

Timvde commented 4 years ago

That's a lot of simplification, fewer features and potentially no support for different density settings? I can merge this if nobody comes up with a better fix. I sadly can't, the README says "community maintained" for a reason :P

sans-c commented 4 years ago

Well, the only feature missing seems to be the hiding of the bookmarks-toolbar. I suppose that could be done as well, considering how elegant the above version is. This reddit seems to be a very good source for this kind of thing. I just tested different density settings on Windows, as well as the "drag space" option and have found no issues at first glance. This also works on Linux for me. I cannot test MacOS though.

I guess its fine if people realize that the bookmarks toolbar is not supported. But then again, the previous version was broken for a while now. Perfectly fits my bill at least. :)

matt-h commented 4 years ago

This works to hide the bookmarks bar: https://github.com/MrOtherGuy/firefox-csshacks/blob/d6a1a8663dc91db9a72b5fce0e61cf30f22e59e7/chrome/autohide_bookmarks_toolbar.css

No idea if it should be combined with this one.

Timvde commented 4 years ago

You make a valid point. These are actually two different features. I'll merge this one as it is. Thanks!