search

Tinche / aiofiles

File support for asyncio
Apache License 2.0
2.66k stars 150 forks source link

Add prefix, suffix, dir args to TemporaryDirectory #116

Closed q0w closed 2 years ago

q0w commented 2 years ago

Closes #112 I also used black (maybe I should not?) because there is no rule about the code style

Tinche commented 2 years ago

Looks good. Could you add a line to the changelog in the readme?

codecov-commenter commented 2 years ago

Codecov Report

Merging #116 (5ae63a4) into master (8895eb4) will increase coverage by 0.03%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   89.56%   89.59%   +0.03%     
==========================================
  Files          10       10              
  Lines         297      298       +1     
==========================================
+ Hits          266      267       +1     
  Misses         31       31
Impacted Files Coverage Δ
src/aiofiles/base.py 70.96% <0.00%> (ø)
src/aiofiles/tempfile/__init__.py 95.08% <100.00%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8895eb4...5ae63a4. Read the comment docs.

q0w commented 2 years ago

Done

Tinche commented 2 years ago

Thanks a lot!