search

Tinche / aiofiles

File support for asyncio
Apache License 2.0
2.66k stars 150 forks source link

Add aiofiles.os.path.islink function #126

Closed jpy-git closed 2 years ago

jpy-git commented 2 years ago

This is the os.path equivalent of the symlink check introduced in #125

Docs: https://docs.python.org/3/library/os.path.html#os.path.islink

Added corresponding test.

codecov-commenter commented 2 years ago

Codecov Report

Merging #126 (9eb12e2) into master (313f4a5) will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   89.73%   89.80%   +0.06%     
==========================================
  Files          10       10              
  Lines         302      304       +2     
==========================================
+ Hits          271      273       +2     
  Misses         31       31
Impacted Files Coverage Δ
src/aiofiles/ospath.py 100.00% <100.00%> (ø)
src/aiofiles/os.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 313f4a5...9eb12e2. Read the comment docs.

Tinche commented 2 years ago

Thanks!

Could you also update the docs for all of these too? Both the Usage section and the History section?

jpy-git commented 2 years ago

Could you also update the docs for all of these too? Both the Usage section and the History section?

Will do 😄

jpy-git commented 2 years ago

@Tinche I've updated the docs now. I put the new PRs under 0.9.0 (TBC) in History as a placeholder 😄

Tinche commented 2 years ago

Great, thanks!