search

TinkerSoc / TinkerWeb

Hugo based TinkerSoc website port
http://tinkersoc.org
0 stars 5 forks source link

Stop playing of background video on mobile #39

Closed joannaz closed 6 years ago

joannaz commented 7 years ago

Whenever you access the site on your mobile, the site is fine when loaded, but as soon as you try scrolling, the video becomes full screen and starts playing. (So you'd have to close it which is a hassle etc.)

I'm pretty sure you can have a background video that doesn't fullscreen when interacted with, just needs looking into :)

egelmex commented 7 years ago

What device are you using?

On Thu, 31 Aug 2017 at 13:30 Joanna Zhang notifications@github.com wrote:

Whenever you access the site on your mobile, the site is fine when loaded, but as soon as you try scrolling, the video becomes full screen and starts playing. (So you'd have to close it which is a hassle etc.)

I'm pretty sure you can have a background video that doesn't fullscreen when interacted with, just needs looking into :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/TinkerSoc/TinkerWeb/issues/39, or mute the thread https://github.com/notifications/unsubscribe-auth/AAc7nmEMVNF71RdkrmLNqQTWt23tEPE9ks5sdqdTgaJpZM4PIwdq .

joannaz commented 7 years ago

iPhone 6, iOS 10.3.3

egelmex commented 7 years ago

I can't reproduce on android, and dont' have a iPhone to test with.

On Thu, 31 Aug 2017 at 13:59 Joanna Zhang notifications@github.com wrote:

iPhone 6, iOS 10.3.3

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/TinkerSoc/TinkerWeb/issues/39#issuecomment-326287668, or mute the thread https://github.com/notifications/unsubscribe-auth/AAc7ni87axb-2Er34QppPVE8z1wmsuEDks5sdq4zgaJpZM4PIwdq .

willfurnell commented 7 years ago

I can reproduce on iOS. May be worth not having a video playing on mobile in the background at all, seeing as it'll eat into users data usage and be playing on less powerful devices?

graymalkin commented 7 years ago

You're both right. It's something I did wrong and forgot to correct as I had an android phone. There's some JS which is triggering it, should be easy to remove. I'll look soon.

On 31 Aug 2017, at 16:54, Will Furnell notifications@github.com<mailto:notifications@github.com> wrote:

I can reproduce on iOS. May be worth not having a video playing on mobile in the background at all, seeing as it'll eat into users data usage and be playing on less powerful devices?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/TinkerSoc/TinkerWeb/issues/39#issuecomment-326340639, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADd8RtoddmiTRWAShZFxrEAA7M3Jacjdks5sdtdDgaJpZM4PIwdq.

-- Kentforlife.net - the email service for alumni of the University of Kent