Occultism compatibility issue

[vojthus]

Minecraft version: 1.9.13 Forge version: 44.1.23

Chunk Pregen version: Chunk Pregenerator-1.19.3-4.2.2 Occultism: tested on 1.19.3-1.73.0 and 1.19.3-1.73.2

When both mods are active in a mod pack the Occult mod guidebook entries are missing icons:

How it looks:

How it should be:

I've spoken to the mod author, he can be reached here: https://github.com/klikli-dev/modonomicon https://discord.gg/trE4SHRXvb

[Speiger]

Thank you for reporting it. I'll look into it the soon, at the moment developing new features and i want that to be done first :) Should be hopefully addressed with the next patch!

[Speiger]

Small note to the @klikli-dev. It seems that your rendering isn't correct by default because the "chest" is broken even so chunk pregen isn't included.

This also might be a bug on your side too. I will though check my code and do some testing once i get to it but please make sure its not on your side either.

[klikli-dev]

@Speiger that chest is a good point - I will look into that and check if it reproduces on my end, probably something overlooked when porting to 1.19.3. So disregard the chest for now, that is likely on me.

The vanishing icons seem a bit odd though - they are not reproducing on my side (without chunk pregenerator present). First thing that comes to mind is that maybe you are rendering something in an event and the blitOffset or posestack is not reset correctly? I had similar issues with overlay rendering in occultism (which is very different from this scenario, but the posestack issue may still apply)

EDIT: the chest renders normally on my end. Looking at the screenshot it looks almost as if the model renders the lid behind the body of the chest. @vojthus Do chests look normal for you in your inventory? Also, if you click into the chest category (without chunk pregenerator), how does the chest icon on the first entry look there?

[Speiger]

@klikli-dev the only thing that i am doing with overlays is enable Depth after my overlays have been rendererd. Which technically is not required. On the other hand UI is designed to be rendered in a way where debth testing shouldn't cause issues even if the depth buffer is enabled. Heck most guis work by render order anyways.

[klikli-dev]

@Speiger thanks a lot! I did not happen across it as seemingly most vanilla and other mod render code that does not disable depth testing has other render code before modonomicon's GUI is rendered that does disable it thus never causing the issue.

Only this one and ftb chunks seem to have the timing required to cause it.

But that needs to be fixed on my end so you can close this :)

[Speiger]

@klikli-dev thanks :) If there is any other issues, don't hesitate to notify me, if i can help ill do.