TinyModularThings / IC2Classic

IC2Classic Bugtracker
152 stars 40 forks source link

Too high Repair Cost value will require more XP than the Electric Enchanter can hold for a Combine operation. #954

Closed Geekerandy closed 9 months ago

Geekerandy commented 10 months ago

I'm not sure how exactly you would refer to the function that determines the scaling exponential XP costs of repeatedly anviling items together, but it seems like the Electric Enchanter scales the XP costs of some of its operations based on this function.

For understanding, I will refer to it as Repair Cost. IC2 Classic 1.19.2, IC2Classic-1.19.2-2.0.8.1.jar Forge 43.3.7, the latest as of this issue.

If the Repair Cost is too high, the XP requirement for a Combine operation will exceed the XP capacity of the Electric Enchanter.

image image

This issue is not gamebreaking, as this can be circumvented by disenchanting one enchant off each the book and the pickaxe, which will also clear the Repair Cost from each item as well. Then the enchants can simply be Combined without issue.

It is also worth mentioning that encountering this issue is highly unlikely due to the fact that one will likely use the Electric Enchanter for earlier steps (thus clearing the Repair Cost), as well as just naturally encountering the Anvil "Too Expensive!" message before the XP costs are too high for the Electric Enchanter.

I had to perform a very specific route of combining enchants to barely exceed the XP cap, in a manner one would call "sloppy". Alternatively, having higher-than-vanilla level enchants combined with no limit on Anvil xp may also encounter this issue.

As for how exactly to patch this issue, I would just have the maximum cost for an operation with the Electric Enchanter be 1000 XP.

Geekerandy commented 10 months ago

oh and it looks like the Electric Enchanter uses a period for "1.000 XP", this is for the en_us localization, it should be a comma.

Speiger commented 10 months ago

@Geekerandy no its a comma. A period would be 1 pixel instead of 2

Geekerandy commented 10 months ago

image @Speiger I mean, this looks like one pixel

Speiger commented 10 months ago

OH xD