search

Tiqr / tiqr

Obsolete Github repo for the tiqr.org project. Note that the repository is split into several individual repos, all with a tiqr- prefix
35 stars 16 forks source link

AuthenticationConfirmationActivity dead code? #30

Open SyntaxPolice opened 11 years ago

SyntaxPolice commented 11 years ago

Greetings,

The AuthenticationConfirmationActivity has the call only to _login commented out. This clearly means that these functions are dead code: _login _initChallengeResponse, which calls _requestSessionKey

Less obviously (due to inheritance) it looks like these functions are dead code:

onSessionKeyAvailable (this gets indirectly called by _requestSessionKey() which is dead?) _authenticateAtServer _parseResponse, etc.

This is the majority of code in the file and most of it's duplicated in: AuthenticationPincodeActivity

Can you clarify which parts are dead by removing them?

Here's the code:

https://github.com/SURFnet/tiqr/blob/master/Android/MobileAuth/src/org/tiqr/authenticator/authentication/AuthenticationConfirmationActivity.java