search

TitasGailius / nova-search-relations

This package allow you to include relationship columns into Laravel Nova search query.
Other
353 stars 33 forks source link

Make search case-insensitive for all SQL drivers #16

Closed mikebronner closed 4 years ago

mikebronner commented 5 years ago

Have you had any issues trying this approach? Would be nice to have search be case-insensitive for all drivers. :)

f-liva commented 5 years ago

No way to get this merged I think... I did the same request months ago and my fork was not merged

TitasGailius commented 5 years ago

I'll take a look at this today.

I don't want the search to become somehow different from how the default Laravel Nova search works. If this keeps the same behaviour I'll merge it.

f-liva commented 5 years ago

It is the same behaviour but case insensitive

-- Federico Liva Full Stack Web Developer

Phone: (+39) 340 768 2386 Skype: federico.liva On Tue, Nov 19, 2019 at 10:46am, Titas Gailius < notifications@github.com [notifications@github.com] > wrote: I'll take a look at this today.

I don't want the search to become somehow different from how the default Laravel Nova search works. If this keeps the same behaviour I'll merge it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub [https://github.com/TitasGailius/nova-search-relations/pull/16?email_source=notifications&email_token=AACUQ4G3VTJF5TD27LZ2RX3QUOYWFA5CNFSM4IRMH4U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEENQ5DY#issuecomment-555421327] , or unsubscribe [https://github.com/notifications/unsubscribe-auth/AACUQ4EEBA5WPVDXQHPTH5LQUOYWFANCNFSM4IRMH4UQ] .

TitasGailius commented 4 years ago

I finally got some time to check this. I want the relationship search to behave exactly the same how Nova is behaving with regular search. This PR breaks this consistency.

If you want to adjust the behaviour to your needs, overriding this method is not of a big deal.