search

TomNeyland / angular-dc

AngularJS directives for dc.js
http://tomneyland.github.io/angular-dc/
MIT License
112 stars 58 forks source link

lodash 3.5 #36

Open ruemic opened 9 years ago

ruemic commented 9 years ago

Getting this error when upgrading to lodash 3.5

dc.errors.InvalidStateException {message: "Mandatory attribute chart.dimension is missing on chart[#dc-chart1]", toString: function}angular.js?body=1:9938 (anonymous function)angular.js?body=1:7284 $getangular.js?body=1:12415 $get.Scope.$digestangular.js?body=1:12661 $get.Scope.$applyangular.js?body=1:8273 doneangular.js?body=1:8478 completeRequestangular.js?body=1:8417 xhr.onreadystatechange

jgknott commented 9 years ago

Had to roll back to lodash 2.4.1 to get this working.

smee commented 9 years ago

There is a pull request for this error at #34, not merged yet, though. @TomNeyland Were you able to review this request?

toddlamothe commented 9 years ago

Has this issue been resolved? Receiving the same error with lodash 3.10.1.

dynajoe commented 9 years ago

I'm not a huge fan of being cornered into choosing the version of lodash that I use based on a dependency.

Thoughts on removing lodash as a dependency of this project? Maybe just implement the parts needed to not force others to have to use the same version of lodash?

Any other alternatives I'm not thinking about?

FredLoney commented 8 years ago

The lodash incompatibility is resolved by the #34 patch cited above. The other lodash calls in angular-dc are common, stable and appropriate. I suggest that once the patch is merged, the bower lodash dependency be changed from '~2' to '*'. It is highly unlikely that the remaining lodash functions used by angular-dc would change. However, it is advisable to add a comment for contributors listing the allowed lodash functions.