Update packages and typescript

Tomato6966 / lavalink-client

Easy, flexible and feature-rich lavalink@v4 Client. Both for Beginners and Proficients.

https://tomato6966.github.io/lavalink-client/

MIT License

61 stars 22 forks source link

Closed hwangsihu closed 2 months ago

Tomato6966 commented 2 months ago

Completly unecessary commit

LucasB25 commented 2 months ago

Not necessary but no reason to refuse it, since it contains package updates and improved code readability

EvilG-MC commented 2 months ago

Is it just me or did he modify the dist files directly?

LucasB25 commented 2 months ago

Is it just me or did he modify the dist files directly?

I hadn’t seen lmao

hwangsihu commented 2 months ago

Is it just me or did he modify the dist files directly?

I hadn’t seen lmao

No, I ran NPM RUN Build and it was like this.

Tomato6966 commented 2 months ago

I will not approve this or any other commits/PRs if they contain changes within the dist/docs folder.

Please make sure to remove all changes related to that, then i will review the PR

The dist and docs folder get generated by me on a version publish

hwangsihu commented 2 months ago

Done.

Tomato6966 commented 2 months ago

Now i can see what you did:

Update the versions on package.json ( I will do it via dependabot / manually don't worry)
Remove eslint Why you want to get rid of eslint?

hwangsihu commented 2 months ago

What? I didn't uninstall ESLint. I just changed the version to v9 and migrated.

Tomato6966 commented 2 months ago

Ah my bad didn't see that you also changed to eslint flat config

TY for committing