Tomato6966 / lavalink-client

Easy, flexible and feature-rich lavalink@v4 Client. Both for Beginners and Proficients.
https://tomato6966.github.io/lavalink-client/
MIT License
61 stars 22 forks source link

bug?: bot keep playing after NodeJS shutdown for a random time when using `node.updateSession()` #72

Closed NedcloarBR closed 2 months ago

NedcloarBR commented 2 months ago

So the title kind of says it all I'm testing the resuming functions and I came across this

EvilG-MC commented 2 months ago

The purpose of the updateSession is to temporarily maintain the playback through the node on everything the bot reconnects.

NedcloarBR commented 2 months ago

Given that, shouldn't it keep playing for the time specified in the function instead of being random as it's happening to me? I set up the function in 6 minutes but the time is around 40 - 80 seconds

Tomato6966 commented 2 months ago

The function allows the lavalink (server) node to play the audio for the given time (second parameter) in ms. Lavalink (server) handels the audio playback...

The point of resuming is that you can keep playing, while restarting the bot, or reconfiguring it (e.g. unmounting events and re-mountin them)

The function does not control it, it just tells lavalink (server) the limit. If you feel like it stops playing before the time you declare it is allowed to please ask in lavalink support.

Note that it of course stops playing when the songs finishes... lavalink (server) has no queue, the client (lavalink-client) handles that