GUI Dev - Githubissues

Tomivix / hpa

First release (v0.9.9) is available here: https://github.com/Tomivix/hpa/raw/master/rel/HPA_Studio_0.9.9_%5B576235A3%5D.jar

Other

5 stars 2 forks source link

GUI Dev #31

Open Aicedosh opened 7 years ago

Aicedosh commented 7 years ago

(Finally) added "flag register" and "help"/"about" dialog

Also the label containing info about step delay is no longer chaning its width

Don't mind the Drag&Drop commits as thos changes are no longer present (maybe as a comment)

mrwasp commented 7 years ago

Ok, I looked at this code, and: 1) help button works good, I'll create graphics for it, but maybe it should be on the left side? 2) The state register ... is, but I do not like how it looks, it breaks symmetry

Tomivix commented 7 years ago

I'm gonna agree with @mrwasp on this one @Aicedosh, but good job nevertheless. The help button will probably fit better on the left side of the top bar. The flag register will do for now (for the lack of any better ideas) but the label above it should be shortened one way or the other (right now it's twice as long as the real thing). Also please move the slider label beneath the slider (I remember you mentioning it's possible).

Aicedosh commented 7 years ago

I've been thinking about the stuff I'm supposed to implement and I came up with some ideas:

Enginge.buildDirectivesFromString() and buildOrdersFromString() -- replace with one function to return boolean whether was successful or not (allow to properly set buttons state)
Move the implementation of the [next step / "calculate"] to View (better packages management: Swing Timer, also ability to know whether the last instruction was executed in View)
WHERE THE HELL TO PUT THE STATE REGISTER???

Tomivix commented 7 years ago

Okay, first regarding the state register - just leave it be. It doesn't seem like anyone has any better ideas so let's go with this one. It doesn't look good but the other options we were mentioning are no better.

As for the first two ideas you came up with I completely agree. The only question is whether you're saying you will do this or do you just want this to be taken care of by someone from the team, @Aicedosh?